-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform identity management apis #1999
Terraform identity management apis #1999
Conversation
Docs for identity auth endpoints are missing because already the scope for this is high and none was added in the time. And its missing completely thus need to add this to docs later by someone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I left a few comments for you
backend/src/server/routes/v1/identity-kubernetes-auth-router.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-gcp-auth/identity-gcp-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-gcp-auth/identity-gcp-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-service.ts
Outdated
Show resolved
Hide resolved
backend/src/services/identity-kubernetes-auth/identity-kubernetes-auth-service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description 📣
This PR introduces endpoints for identity and identity auth management in terraform. Implemented revoke endpoints for all identity auth and get identity for reading identity
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets